Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: fix and refactor enterprise release pipeline #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Apr 16, 2024

Description of the change

  1. Change the find and replace logic in CI code to use a JavaScript script instead of sed to avoid issues with escaping special characters.
  2. Refactor NN and Injazat's release to use the same job but with different parameters instead of different jobs.
  3. Fix NN, Injazat, and Dream11's packages sourcemaps upload script, the ios/sourcemaps.sh and android/sourcemaps.gradle scripts referred to instabug-reactnative to invoke the upload CLI in the past so we fixed the release pipelines to replace all occurrences of instabug-reactnative with the new package name in these files as well.
  4. Replace the API URL used to upload SO files in the CLI to refer to the API URL of the customer instead of the default Instabug API.

I tested the new release_custom_package and release_d11 CI jobs on the test-only @instabug/react-native-private to make sure things are working fine.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev marked this pull request as draft April 16, 2024 16:28
@InstabugCI
Copy link
Collaborator

InstabugCI commented Apr 16, 2024

Coverage Report

Label Coverage Status
JavaScript 96.3%
Android 47.9%
iOS 41.7%

Generated by 🚫 dangerJS against 968df53

@a7medev a7medev changed the title ci: fix and refactor injazat release pipeline ci: fix and refactor enterprise release pipeline Apr 18, 2024
@a7medev a7medev force-pushed the ci/fix-injazat-release branch from a8c8d08 to 968df53 Compare April 18, 2024 14:10
@a7medev a7medev self-assigned this Apr 18, 2024
@a7medev a7medev marked this pull request as ready for review April 19, 2024 16:04
@mzelzoghbi mzelzoghbi merged commit cf134cf into master Apr 19, 2024
@mzelzoghbi mzelzoghbi deleted the ci/fix-injazat-release branch April 19, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants