Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add w3c header #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 101 commits into from
Sep 19, 2024
Merged

feat: add w3c header #1255

merged 101 commits into from
Sep 19, 2024

Conversation

kholood-ea
Copy link
Contributor

@kholood-ea kholood-ea commented Jul 24, 2024 •
edited
Loading

Description of the change

  • Add traceparent header to network requests
  • Add W3C attributes to APM network logs

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JiraID:MOB-14496

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

abdelhamid-f-nasser and others added 30 commits July 17, 2024 16:56
@abdelhamid-f-nasser
feat(example): add apm screen (#1141)
1ddc5e3
@a7medev
fix(android): resolve an OOM in network logs (#1244)
0222c64
@kholood-ea
fix(android): APM network logging(#1253)
635cd47 
* fix(android): add W3C External Trace Attributes placeholder

* chore: add CHANGLOG

* chore: add CHANGLOG

* fix: remove ios sub module
@a7medev @kholood-ea
fix: use correct diff link for v13.0.0, v12.9.0 releases (#1198)
4e81621
@a7medev @kholood-ea
feat(ios): read env vars from .xcode.env in sourcemaps script (#1200)
3073554 
* feat(ios): read env vars from .xcode.env in sourcemaps script

* chore: update xcode project

* chore: update changelog
@kholood-ea
chore/update-podfile.lock
8d16747
@kholood-ea
feat: add w3c header generator
e546e93
@kholood-ea
ci:fix lint
b8c2872
@kholood-ea
ci:fix ios tests
3f1ac4f
@kholood-ea
feat:update header format
d08d3f2
@kholood-ea
feat:update header format test case title
be7e75c
@kholood-ea
feat:Inject the W3C Header to Network Requests
3032124
@kholood-ea
ci:fix lint
04b9248
@kholood-ea
feat:remove tracestate
3891e75
@kholood-ea
feat: get feature flags from IOS
a3d5ae8
@kholood-ea
ci: fix ios test
6af6690
@kholood-ea
fix: modify function naming
f74fa14
@kholood-ea
fix: update APM test cases
112773d
@kholood-ea
fix: update native test cases naming
044f1b2
@kholood-ea
feat(ios): w3c logs mapping
d99839a
@kholood-ea
fix: export number partial id
d5d8e26
@kholood-ea
fix: modify partial id generator function
dd293d8
@kholood-ea
fix: modify partial id generator test cases
332b054
@kholood-ea
feat(example): add network request generators buttons
1d105aa
@kholood-ea
ci: fix lint
1c96a4a
@kholood-ea
ci(example): add missing import
648ca24
@kholood-ea
feat(android): map apm network logs
eaeb703
@kholood-ea
feat(android): add W3C native modules & tests
7297a63
@kholood-ea
feat: map w3c android native modules and test
af54f6a
@kholood-ea
feat: register w3c feature change listener
6779026
a7medev
a7medev requested changes Sep 17, 2024
View reviewed changes
@kholood-ea kholood-ea removed the WIP Work In Progress label Sep 18, 2024
@kholood-ea kholood-ea requested a review from a7medev September 18, 2024 10:14
a7medev
a7medev previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job @kholood-ea, very great effort has been put into this! 👏🏼👏🏼

AyaMahmoud148
AyaMahmoud148 previously approved these changes Sep 18, 2024
View reviewed changes
@kholood-ea kholood-ea dismissed stale reviews from AyaMahmoud148 and a7medev via 6fef4f3 September 18, 2024 12:02
@kholood-ea kholood-ea force-pushed the fix/w3c-defects-revert branch from 6fef4f3 to b24213e Compare September 18, 2024 13:59
@a7medev a7medev merged commit 69d7c94 into dev Sep 19, 2024
10 of 12 checks passed
@a7medev a7medev deleted the fix/w3c-defects-revert branch September 19, 2024 09:28
@a7medev a7medev mentioned this pull request Sep 22, 2024
Merged
7 tasks
@a7medev a7medev restored the fix/w3c-defects-revert branch September 22, 2024 13:13
a7medev added a commit that referenced this pull request Sep 22, 2024
@a7medev
Revert "feat: add w3c header (#1255)"
c3a87e5 
This reverts commit 69d7c94.
@a7medev a7medev mentioned this pull request Sep 22, 2024
Merged
a7medev added a commit that referenced this pull request Sep 23, 2024
@a7medev
Revert "feat: add w3c header (#1255)" (#1287)
915fb73 
This reverts commit 69d7c94.
YoussefFouadd pushed a commit that referenced this pull request Oct 16, 2024
@kholood-ea @YoussefFouadd
feat: add w3c header (#1255)
ebad7e8 
Signed-off-by: YoussefFouadd <[email protected]>
YoussefFouadd pushed a commit that referenced this pull request Oct 16, 2024
@a7medev @YoussefFouadd
Revert "feat: add w3c header (#1255)" (#1287)
5675da4 
This reverts commit 69d7c94.

Signed-off-by: YoussefFouadd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

@AyaMahmoud148 AyaMahmoud148 AyaMahmoud148 approved these changes

@ahmedAlaaInstabug ahmedAlaaInstabug Awaiting requested review from ahmedAlaaInstabug

@AndrewAminInstabug AndrewAminInstabug Awaiting requested review from AndrewAminInstabug

Assignees

@kholood-ea kholood-ea

Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kholood-ea @InstabugCI @a7medev @AyaMahmoud148 @abdelhamid-f-nasser @ahmedAlaaInstabug