Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(android): resolve correct app version with flavors in source map upload #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(android): resolve correct app version with flavors in source map upload #1289

merged 1 commit into from
Sep 25, 2024

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Sep 25, 2024

Description of the change

Resolve the correct app version name and version code to use when uploading the source map file to the dashboard on Android when using different versions for different variants/flavors (e.g. flavors that set a suffix to the version name).

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: INSD-11595

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 25, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 98.4% ✅
Android 50.2% ✅
iOS 47.9% ✅

Generated by 🚫 dangerJS against d80ab2c

kholood-ea
kholood-ea previously approved these changes Sep 25, 2024
View reviewed changes
@a7medev a7medev force-pushed the fix/resolve-flavor-version branch from dc932d0 to d80ab2c Compare September 25, 2024 11:10
@a7medev a7medev changed the base branch from release/13.4.0 to dev September 25, 2024 11:10
@a7medev a7medev dismissed stale reviews from kholood-ea and ahmedAlaaInstabug September 25, 2024 11:10

The base branch was changed.

@a7medev a7medev merged commit b119f83 into dev Sep 25, 2024
10 of 12 checks passed
@a7medev a7medev deleted the fix/resolve-flavor-version branch September 25, 2024 14:59
YoussefFouadd pushed a commit that referenced this pull request Oct 16, 2024
@a7medev @YoussefFouadd
fix(android): resolve correct app version with flavors (#1289)
41dd1cd 
Signed-off-by: YoussefFouadd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kholood-ea kholood-ea kholood-ea approved these changes

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

@AndrewAminInstabug AndrewAminInstabug Awaiting requested review from AndrewAminInstabug

@AyaMahmoud148 AyaMahmoud148 Awaiting requested review from AyaMahmoud148

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a7medev @InstabugCI @kholood-ea @ahmedAlaaInstabug