Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add new hybrid app #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 29, 2024
Merged

feat: add new hybrid app #1301

merged 20 commits into from
Oct 29, 2024

Conversation

AyaMahmoud148
Copy link
Contributor

@AyaMahmoud148 AyaMahmoud148 commented Oct 24, 2024 •
edited
Loading

Description of the change

Adding new hybrid app application to be able test (Dream11) configuration and automate the release checks

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

InstabugCI commented Oct 24, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 98.4% ✅
Android 50.2% ✅
iOS 49.4% ✅

Generated by 🚫 dangerJS against 1e0e923

@AyaMahmoud148 AyaMahmoud148 force-pushed the feat/add-new-hybrid-app branch from c74a77d to 0efbea5 Compare October 24, 2024 10:44
@AyaMahmoud148 AyaMahmoud148 force-pushed the feat/add-new-hybrid-app branch from 0efbea5 to f161d07 Compare October 24, 2024 11:19
a7medev
a7medev requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing effort @AyaMahmoud148 👏🏼❤️

I've added some small comments please check them out and let me know your thoughts. Also, I think we can rename the app to examples/hybrid for readability.

@AyaMahmoud148 AyaMahmoud148 force-pushed the feat/add-new-hybrid-app branch from ded69bc to d8034c0 Compare October 27, 2024 15:06
a7medev
a7medev approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @AyaMahmoud148! 👏🏼

kholood-ea
kholood-ea approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@kholood-ea kholood-ea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent Effort @AyaMahmoud148 👏🏻

@AyaMahmoud148 AyaMahmoud148 merged commit 300780c into feat/enterprise-release-post-checks Oct 29, 2024
10 of 11 checks passed
@AyaMahmoud148 AyaMahmoud148 deleted the feat/add-new-hybrid-app branch October 29, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kholood-ea kholood-ea kholood-ea approved these changes

@a7medev a7medev a7medev approved these changes

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

@AndrewAminInstabug AndrewAminInstabug Awaiting requested review from AndrewAminInstabug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AyaMahmoud148 @InstabugCI @kholood-ea @a7medev @ahmedAlaaInstabug