Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: enable/disable auto masking screenshots in rn #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 7, 2025
Merged

feat: enable/disable auto masking screenshots in rn #1353

merged 10 commits into from
Apr 7, 2025

Conversation

AyaMahmoud148
Copy link
Contributor

@AyaMahmoud148 AyaMahmoud148 commented Mar 3, 2025 •
edited
Loading

Description of the change

Enabling and disabling screenshot automasking in RN

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

https://instabug.atlassian.net/browse/MOB-17534

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@AyaMahmoud148 AyaMahmoud148 changed the base branch from master to dev March 3, 2025 13:14
@AyaMahmoud148 AyaMahmoud148 marked this pull request as draft March 3, 2025 13:16
@InstabugCI
Copy link
Collaborator

InstabugCI commented Mar 3, 2025 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 95.1% ✅
Android 50.5% ✅
iOS 51.5% ✅

Generated by 🚫 dangerJS against f9c5bd8

@AyaMahmoud148 AyaMahmoud148 marked this pull request as ready for review March 4, 2025 12:55
ahmedAlaaInstabug
ahmedAlaaInstabug reviewed Mar 4, 2025
View reviewed changes
@AyaMahmoud148 AyaMahmoud148 force-pushed the feat/Auto-masking-screenshots-in-RN branch from 0108b42 to f72131f Compare March 5, 2025 13:51
kholood-ea
kholood-ea previously approved these changes Mar 6, 2025
View reviewed changes
@ahmedAlaaInstabug ahmedAlaaInstabug dismissed stale reviews from kholood-ea, AndrewAminInstabug, and themself via ef2f6ab March 9, 2025 13:32
@AyaMahmoud148 AyaMahmoud148 force-pushed the feat/Auto-masking-screenshots-in-RN branch 2 times, most recently from f9c5bd8 to 7186234 Compare March 12, 2025 10:40
@MoniraOsama MoniraOsama added the READY FOR MERGE Reviewed and ready for merge (after release request) label Mar 12, 2025
kholood-ea
kholood-ea previously approved these changes Mar 12, 2025
View reviewed changes
@AyaMahmoud148 AyaMahmoud148 force-pushed the feat/Auto-masking-screenshots-in-RN branch from 7186234 to 6ddfb47 Compare March 25, 2025 13:44
@AyaMahmoud148 AyaMahmoud148 force-pushed the feat/Auto-masking-screenshots-in-RN branch 2 times, most recently from 7186234 to ed8680d Compare March 25, 2025 13:49
@AyaMahmoud148 AyaMahmoud148 force-pushed the feat/Auto-masking-screenshots-in-RN branch from ed8680d to 0ac631b Compare March 25, 2025 13:55
@AyaMahmoud148 AyaMahmoud148 merged commit c116eae into dev Apr 7, 2025
8 of 9 checks passed
@AyaMahmoud148 AyaMahmoud148 deleted the feat/Auto-masking-screenshots-in-RN branch April 7, 2025 08:05
AyaMahmoud148 added a commit that referenced this pull request Apr 13, 2025
@AyaMahmoud148
Revert "Merge pull request #1353 from Instabug/feat/Auto-masking-scre…
876d11c 
…enshots-in-RN"

This reverts commit c116eae, reversing
changes made to 0523b05.
mzelzoghbi pushed a commit that referenced this pull request Apr 13, 2025
@AyaMahmoud148
chore: [revert] network spans and screenshot auto masking (#1374)
dc3cc97 
* chore: Revert network spans

* fix: use ios 14.3.0

* fix: sync pod file

* Revert "Merge pull request #1353 from Instabug/feat/Auto-masking-screenshots-in-RN"

This reverts commit c116eae, reversing
changes made to 0523b05.

* fix: fix linting

* fix: revert android
@kholood-ea kholood-ea restored the feat/Auto-masking-screenshots-in-RN branch May 9, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoKamall MoKamall MoKamall approved these changes

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

@kholood-ea kholood-ea Awaiting requested review from kholood-ea

@AndrewAminInstabug AndrewAminInstabug Awaiting requested review from AndrewAminInstabug

Assignees
No one assigned
Labels
READY FOR MERGE Reviewed and ready for merge (after release request)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AyaMahmoud148 @InstabugCI @kholood-ea @MoKamall @ahmedAlaaInstabug @AndrewAminInstabug @MoniraOsama