feat: Support Advanced UI customization #1411
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kholood-ea
reviewed
Jul 7, 2025
Comment on lines
+1508
to
+1517
| try { | ||
| Typeface typeface = Typeface.createFromAsset(getReactApplicationContext().getAssets(), "fonts/" + fileName); | ||
| return typeface; | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| } | ||
| } | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| } |
There was a problem hiding this comment.
how about extracting this to a new function instead of writing the same logic twice ?
There was a problem hiding this comment.
we still have the same logic written twice, I was thinking something more like
public static Typeface loadTypefaceFromAssets(Context context, String fileName) {
try {
return Typeface.createFromAsset(context.getAssets(), "fonts/" + fileName);
} catch (Exception e) {
e.printStackTrace();
return null;
}
}
then drop the double try catch blocks
kholood-ea
reviewed
Jul 7, 2025
android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java
Show resolved
Hide resolved
kholood-ea
reviewed
Jul 7, 2025
kholood-ea
reviewed
Jul 7, 2025
|
Great effort @AyaMahmoud148 👏🏻 |
ahmedAlaaInstabug
approved these changes
Jul 9, 2025
kholood-ea
reviewed
Jul 11, 2025
Comment on lines
+1372
to
+1386
| if (themeConfig.hasKey("primaryColor")) { | ||
| builder.setPrimaryColor(getColor(themeConfig, "primaryColor")); | ||
| } | ||
| if (themeConfig.hasKey("secondaryTextColor")) { | ||
| builder.setSecondaryTextColor(getColor(themeConfig, "secondaryTextColor")); | ||
| } | ||
| if (themeConfig.hasKey("primaryTextColor")) { | ||
| builder.setPrimaryTextColor(getColor(themeConfig, "primaryTextColor")); | ||
| } | ||
| if (themeConfig.hasKey("titleTextColor")) { | ||
| builder.setTitleTextColor(getColor(themeConfig, "titleTextColor")); | ||
| } | ||
| if (themeConfig.hasKey("backgroundColor")) { | ||
| builder.setBackgroundColor(getColor(themeConfig, "backgroundColor")); | ||
| } |
There was a problem hiding this comment.
for colors instead of adding a check for every one we can extract the logic
private void applyColorIfPresent(ReadableMap config, com.instabug.library.model.IBGTheme.Builder builder, String key, Consumer<Integer> setter) {
if (config.hasKey(key)) {
setter.accept(getColor(config, key));
}
}
then call it for each color
applyColorIfPresent(themeConfig, builder, "primaryColor", builder::setPrimaryColor);
kholood-ea
reviewed
Jul 11, 2025
Comment on lines
+1388
to
+1395
| if (themeConfig.hasKey("primaryTextStyle")) { | ||
| builder.setPrimaryTextStyle(getTextStyle(themeConfig, "primaryTextStyle")); | ||
| } | ||
| if (themeConfig.hasKey("secondaryTextStyle")) { | ||
| builder.setSecondaryTextStyle(getTextStyle(themeConfig, "secondaryTextStyle")); | ||
| } | ||
| if (themeConfig.hasKey("ctaTextStyle")) { | ||
| builder.setCtaTextStyle(getTextStyle(themeConfig, "ctaTextStyle")); |
There was a problem hiding this comment.
same as previous comment
kholood-ea
reviewed
Jul 11, 2025
| private void setFontIfPresent(ReadableMap themeConfig, com.instabug.library.model.IBGTheme.Builder builder, | ||
| String fileKey, String assetKey, String fontType) { | ||
| if (themeConfig.hasKey(fileKey) || themeConfig.hasKey(assetKey)) { | ||
| Typeface typeface = getTypeface(themeConfig, fileKey, assetKey); |
There was a problem hiding this comment.
if we might not need both fileKey and assetKey inside then lets have a function that does one thing for each of them and not drop all the logic inside getTypeface
public static Typeface loadTypefaceFromFile(Context context, String fileName) {
...
}
public static Typeface loadTypefaceFromAssets(Context context, String assetKey) {
...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review