Allow RN package initialization to configure crash reporting #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpetzel thanks for the pull request. This makes sense. We will give it a round of testing then merge it. |
salmamali
approved these changes
Jan 22, 2019
|
@cpetzel this is included in v8.0.23, which will be available shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the Instabug React Native Android SDK will enable crash reporting, which will set the default thread exception handler... If I want to use a different crash handler, I have no option of disabling this, until my javascript code executes
Instabug.setCrashReportingEnabled(false);. This means that there are potentially a few seconds of critical startup time where crashes will be sent to instabug.This PR lets the developer opt out of crash reporting when initializing the Instabug React Native package.