Fixing Yarn issue in CI #528
Conversation
alyezz
commented
Oct 12, 2020
- Fixes an issue causing the CI to fail due to Yarn
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 21 21
Lines 381 381
Branches 72 72
=======================================
Hits 340 340
Misses 36 36
Partials 5 5 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
It's probably not the best idea to ignore the node engine version incompatibilities. Although it's working now, it could easily break in the future.
Having a look at the release history for the library teeny-request which codecov depends on, I can see in v7 they've upgraded their node engine. Updating codecov from v3.7 to v3.8 which in turn updates teeny-request from v6 to v7 which causes incompatibility.
A temporary solution here until we decide to upgrade our CI node engine.