Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[INSD-5219] Fix BugReporting.setVideoRecordingFloatingButtonPosition #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2021
Merged

[INSD-5219] Fix BugReporting.setVideoRecordingFloatingButtonPosition #560

merged 4 commits into from
Apr 21, 2021

Conversation

AliAbdelfattah
Copy link
Contributor

Description of the change

  • Added BugReporting.setVideoRecordingFloatingButtonPosition
  • Deprecated Instabug.setVideoRecordingFloatingButtonPosition

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@AliAbdelfattah AliAbdelfattah self-assigned this Mar 29, 2021
AliAbdelfattah
AliAbdelfattah commented Apr 9, 2021
View reviewed changes
AliAbdelfattah
AliAbdelfattah commented Apr 9, 2021
View reviewed changes
@AliAbdelfattah AliAbdelfattah force-pushed the fix/setVideoRecordingFloatingButtonPosition branch from 7cb1bd4 to 38a6eb7 Compare April 9, 2021 14:10
@codecov
Copy link

codecov bot commented Apr 9, 2021 •
edited
Loading

Codecov Report

Merging #560 (c3cb210) into rel/10.3.0 (67e86ab) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c3cb210 differs from pull request most recent head 72a4177. Consider uploading reports for the commit 72a4177 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           rel/10.3.0     #560   +/-   ##
===========================================
  Coverage       86.08%   86.08%           
===========================================
  Files              24       24           
  Lines             424      424           
  Branches           82       82           
===========================================
  Hits              365      365           
  Misses             49       49           
  Partials           10       10
Impacted Files Coverage Δ
index.js 78.12% <ø> (-0.17%) ⬇️
jest/mockBugReporting.js 100.00% <ø> (ø)
jest/mockInstabug.js 100.00% <ø> (ø)
modules/BugReporting.js 93.33% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e86ab...72a4177. Read the comment docs.

@AliAbdelfattah AliAbdelfattah force-pushed the fix/setVideoRecordingFloatingButtonPosition branch from 38a6eb7 to c3cb210 Compare April 9, 2021 15:11
@AliAbdelfattah AliAbdelfattah added the READY FOR MERGE Reviewed and ready for merge (after release request) label Apr 19, 2021
@AliAbdelfattah AliAbdelfattah changed the base branch from master to rel/10.3.0 April 21, 2021 22:59
@AliAbdelfattah AliAbdelfattah merged commit d3bf8fc into rel/10.3.0 Apr 21, 2021
@AliAbdelfattah AliAbdelfattah deleted the fix/setVideoRecordingFloatingButtonPosition branch April 21, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmed1hisham ahmed1hisham ahmed1hisham approved these changes

@bsameh-at-instabug bsameh-at-instabug bsameh-at-instabug approved these changes

Assignees

@AliAbdelfattah AliAbdelfattah

Labels
READY FOR MERGE Reviewed and ready for merge (after release request)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AliAbdelfattah @ahmed1hisham @bsameh-at-instabug