Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MOB-5157] Add new API: Replies.showNotificationAndroid #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2021
Merged

[MOB-5157] Add new API: Replies.showNotificationAndroid #569

merged 4 commits into from
Apr 22, 2021

Conversation

AliAbdelfattah
Copy link
Contributor

Description of the change

Added new API: Replies.showNotificationAndroid

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@AliAbdelfattah AliAbdelfattah self-assigned this Apr 9, 2021
@ahmed1hisham ahmed1hisham force-pushed the hotfix/android-push-notifications branch from e0cd90c to b830f22 Compare April 17, 2021 13:40
@codecov
Copy link

codecov bot commented Apr 17, 2021 •
edited
Loading

Codecov Report

Merging #569 (1f7f5e6) into rel/10.3.0 (d3bf8fc) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           rel/10.3.0     #569      +/-   ##
==============================================
+ Coverage       86.08%   86.15%   +0.06%     
==============================================
  Files              24       24              
  Lines             424      426       +2     
  Branches           82       83       +1     
==============================================
+ Hits              365      367       +2     
  Misses             49       49              
  Partials           10       10
Impacted Files Coverage Δ
jest/mockReplies.js 100.00% <ø> (ø)
modules/Replies.js 95.45% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bf8fc...1f7f5e6. Read the comment docs.

@AliAbdelfattah AliAbdelfattah force-pushed the hotfix/android-push-notifications branch 2 times, most recently from c92665f to 6868e08 Compare April 22, 2021 02:32
@AliAbdelfattah AliAbdelfattah changed the base branch from master to rel/10.3.0 April 22, 2021 02:34
@AliAbdelfattah AliAbdelfattah changed the title Add new API: Replies.showNotificationAndroid [MOB-5157] Add new API: Replies.showNotificationAndroid Apr 22, 2021
@AliAbdelfattah AliAbdelfattah force-pushed the hotfix/android-push-notifications branch from 6868e08 to 914cef0 Compare April 22, 2021 02:36
@AliAbdelfattah AliAbdelfattah marked this pull request as ready for review April 22, 2021 02:38
@AliAbdelfattah AliAbdelfattah force-pushed the hotfix/android-push-notifications branch from 6d85788 to 1f7f5e6 Compare April 22, 2021 03:00
@AliAbdelfattah AliAbdelfattah merged commit 702e030 into rel/10.3.0 Apr 22, 2021
@AliAbdelfattah AliAbdelfattah deleted the hotfix/android-push-notifications branch April 22, 2021 10:33
@AliAbdelfattah AliAbdelfattah restored the hotfix/android-push-notifications branch May 26, 2021 08:56
@AliAbdelfattah AliAbdelfattah deleted the hotfix/android-push-notifications branch May 26, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmed1hisham ahmed1hisham ahmed1hisham approved these changes

Assignees

@AliAbdelfattah AliAbdelfattah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliAbdelfattah @ahmed1hisham