Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix/parse error stack hermes support #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 24, 2021
Merged

Fix/parse error stack hermes support #614

merged 4 commits into from
Aug 24, 2021

Conversation

shehabeldeenibrahim
Copy link
Contributor

@shehabeldeenibrahim shehabeldeenibrahim commented Aug 19, 2021 •
edited
Loading

Description of the change

  • Changed parseErrorStack parameters based on RN version, which has been updated in RN Version 0.64
  • IBG now working properly with Hermes

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

AliAbdelfattah
AliAbdelfattah approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@AliAbdelfattah AliAbdelfattah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪

@AliAbdelfattah AliAbdelfattah changed the base branch from master to release/10.8.1 August 24, 2021 17:48
@AliAbdelfattah AliAbdelfattah merged commit 50219f6 into release/10.8.1 Aug 24, 2021
@AliAbdelfattah AliAbdelfattah deleted the fix/parseErrorStack-HermesSupport branch August 24, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliAbdelfattah AliAbdelfattah AliAbdelfattah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shehabeldeenibrahim @AliAbdelfattah