Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MOB-12243] Fix iOS Sourcemaps Script in Debug #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2023
Merged

[MOB-12243] Fix iOS Sourcemaps Script in Debug #961

merged 3 commits into from
Apr 18, 2023

Conversation

DavidMina96
Copy link
Contributor

Description of the change

  • In debug mode, react-native doesn't generate a source map file, and hence the build was failing due to instabug CLI being called without $source_map_file. This is fixed by exiting the script in debug mode.
  • Replace exit 1s by exit 0s not to affect the build process if the corresponding conditions are met.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@DavidMina96 DavidMina96 requested a review from a7medev April 18, 2023 12:01
@DavidMina96 DavidMina96 self-assigned this Apr 18, 2023
@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
JavaScript 96.8% ✅
Android 47.8% ✅
iOS 39.0% ✅

Generated by 🚫 dangerJS against f81070f

@DavidMina96 DavidMina96 merged commit b510919 into dev Apr 18, 2023
@DavidMina96 DavidMina96 deleted the fix/ios-sourcemaps branch April 18, 2023 15:36
HeshamMegid pushed a commit that referenced this pull request Apr 20, 2023
@DavidMina96 @HeshamMegid
[MOB-12243] Fix iOS Sourcemaps Script in Debug (#961)
8c64320 
Exit the script in debug mode as react-native doesn't generate a source map file in this case.
Replace exit 1s by exit 0s not to affect the build process if the corresponding conditions are met.
a7medev pushed a commit that referenced this pull request Apr 25, 2023
@DavidMina96 @a7medev
[MOB-12243] Fix iOS Sourcemaps Script in Debug (#961)
3c7cf67 
Exit the script in debug mode as react-native doesn't generate a source map file in this case.
Replace exit 1s by exit 0s not to affect the build process if the corresponding conditions are met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

Assignees

@DavidMina96 DavidMina96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidMina96 @InstabugCI @a7medev