Classic player death sound option #2403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ties classic player death sound to combats vocalization. Rationale: - players bothered by "non standard" death gasp are more than likely also bothered by combats vocalization; - on the other hand I see a possible case for players that don't want combats vocalization but like race and gender aware death sounds. Seems pretty niche case though.
|
"Nyuck!" makes a comeback. :) Your reasoning is fine here and I'm happy with the approach. Preferable to making yet another launcher option for such a minor thing. Thank you @petchema! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ties classic player death sound to combats vocalization; No combats vocalization <=> classic player death sound.
Rationale: