fix(core): report 0 loops for a still image - #126
Merged
Conversation
loops() read the loop field unguarded and threw a DriverException on any image without one, that is every still image, decoded or created. GD and Imagick report 0 there. Guard the read like count() does for n-pages.
deluxetom
approved these changes
Sep 8, 2026
Member
|
Thanks. |
olivervogel
pushed a commit
that referenced
this pull request
Sep 9, 2026
loops() read the loop field unguarded and threw a DriverException on any image without one, that is every still image, decoded or created. GD and Imagick report 0 there. Guard the read like count() does for n-pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$image->loops()on a still image throws with the vips driver:GD returns 0 (its default), Imagick returns
getImageIterations(), 0 for a still image. The vipsCore::loops()read theloopfield unguarded. It now checks the field first and returns 0 when it is missing, likecount()does forn-pages.