Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: payment QR code for web/pdf templates #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2023
Merged

feat: payment QR code for web/pdf templates #995

merged 3 commits into from
Nov 5, 2023

Conversation

mheiduk
Copy link
Contributor

@mheiduk mheiduk commented Oct 25, 2023 •
edited
Loading

Description

Adding payment QR code feature for web/pdf invoice templates. Due to the pull request #987 redesigning the default invoice templates, I didn't add the QR code image to the invoice templates just yet. Tested it with the current ones though. If you want it in the current invoice templates anyway, then I can add it.

For testing just add the following helper function inside web/pdf templates:

<?php echo invoice_qrcode($invoice->invoice_id); ?>

Related Issue

Forum thread: https://community.invoiceplane.com/t/topic/9627/3

Motivation and Context

I need this feature for a client. Furthermore it is quite common today to pay with QR code via banking apps.

Screenshots (if appropriate):

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

@mheiduk mheiduk force-pushed the feature/qr-code-payment branch from 18336d4 to b4ecff0 Compare October 25, 2023 16:47
@nielsdrost7
Copy link
Contributor

@mheiduk

Thanks for the PR, man!

If you want it in the current invoice templates anyway, then I can add it

Yes, please add it.

I'll take a look very soon at the rest of the PR.

@mheiduk
Copy link
Contributor Author

mheiduk commented Oct 25, 2023

@mheiduk

Thanks for the PR, man!

If you want it in the current invoice templates anyway, then I can add it

Yes, please add it.

I'll take a look very soon at the rest of the PR.

Sure! QR code image and payment info added to the invoice templates.

nielsdrost7 added a commit that referenced this pull request Nov 5, 2023
@nielsdrost7
#995: Improve translation just a tiny bit
0499003
@nielsdrost7 nielsdrost7 merged commit 9773125 into InvoicePlane:development Nov 5, 2023
@Verony-makesIT Verony-makesIT mentioned this pull request Dec 5, 2023
Merged
7 tasks
nielsdrost7 added a commit that referenced this pull request Dec 16, 2023
@nielsdrost7
#995: Improve translation just a tiny bit
1ae2094
@Verony-makesIT
Copy link
Contributor

@mheiduk, I would like to test/use your QRcode feature but I can’t find a decent explanation of it anywhere.
More specifically, I would like to know where in my template file(s) I can adjust and/or set the QrCode settings?
Currently I would like to know where I can adjust or set the height and width, foreground and background colors, border and margin and possibly also if a logo is possible in the QrCode?
Some examples would already help.

@mheiduk
Copy link
Contributor Author

mheiduk commented Feb 25, 2024 •
edited
Loading

@mheiduk, I would like to test/use your QRcode feature but I can’t find a decent explanation of it anywhere. More specifically, I would like to know where in my template file(s) I can adjust and/or set the QrCode settings? Currently I would like to know where I can adjust or set the height and width, foreground and background colors, border and margin and possibly also if a logo is possible in the QrCode? Some examples would already help.

@Verony-makesIT Sorry for the late reply. You can find the QR-Code settings in System Settings > Invoices > QR Code settings. There you can set the recipient, IBAN, BIC and remittance text. Height and width of the QR code is changable via CSS #invoice-qr-code. Foreground and background colors and a custom logo inside of the QR code is not supported yet. But it would be a nice addition imo. You could create an issue and I would look into it.

@Verony-makesIT
Copy link
Contributor

@mheiduk,
Thanks for this answer, but I am going to stick (for now?) with the old and integrated (barcode - QRcode) solution in mPDF, which is clearer, more flexible and easier to handle/use for me.

@Verony-makesIT Verony-makesIT mentioned this pull request Apr 30, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mheiduk @nielsdrost7 @Verony-makesIT