[#11] 제보사이트 - 코드 리뷰 반영 #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeisneverodd
approved these changes
Jul 1, 2022
| </DataList> | ||
| </StepByStepInputItem> | ||
|
|
||
| {isDetailContentUnvisible ? null : ( |
There was a problem hiding this comment.
!isDetailContentUnvisible && (<></>) 와 논리곱 연산자를 써도 좋을 것 같아요! A && B 는 A가 참이여야 B를 수행하고, A가 거짓이면 아무것도 실행하지 않는 것을 뜻합니다.
| @@ -0,0 +1,27 @@ | |||
| // Tabs에서 공통적으로 사용되는 부분을 위해 폴더구조를 이렇게 만들었는데, 뭔가 어색하네요.. | |||
There was a problem hiding this comment.
이 부분은 저도 공감해요! 아마 아래있는 style 들은 저희가 report 들에 공통적으로 들어갈 component를 만든다면 그 안에 들어갈 내용이 될 거라고 생각합니다 ㅎㅎ
| </DataList> | ||
| </StepByStepInputItem> | ||
|
|
||
| {isDetailContentUnvisible ? null : ( |
There was a problem hiding this comment.
A && ()
!isDetailContentVisible && ()
앞의 조건이 true인 경우에만 뒤에 것을 시행합니다.
병합 연산자??
| @@ -7,17 +8,17 @@ import SolutionReport from "./Tabs/SolutionReport"; | |||
| export default function TabNavigation() { | |||
There was a problem hiding this comment.
아래와 같은 폴더구조를 생각해보셔도 좋을 것 같아요!!
router.js
routes.js
App.js
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
관련 Issue
Close #11
생각해볼 내용
이후 작업할 내용