Unsupported statement #1519
Merged
Unsupported statement #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parallel Test execution Gradle Caching Explicitly request for latest JavaCC 7.0.10
Parallel Test execution Gradle Caching Explicitly request for latest JavaCC 7.0.10
Parallel Test execution Gradle Caching Explicitly request for latest JavaCC 7.0.10
Parallel Test execution Gradle Caching Explicitly request for latest JavaCC 7.0.10
- Add Feature allowUnsupportedStatement, default=false - Fully implement UnsupportedStatement for the Statement() production - Partially implement UnsupportedStatement for the Statements() production, works only when UnsupportedStatement comes first
Disable STATEMENTS() test, which will never fail and add comments to this regard
wumpz
approved these changes
May 11, 2022
| try { | ||
| (stm = SingleStatement() | stm = Block()) { list.add(stm); } <ST_SEMICOLON> | ||
| ( (stm = SingleStatement() | stm = Block()) <ST_SEMICOLON> { list.add(stm); } )* | ||
| ( |
There was a problem hiding this comment.
To be honest I find your version much harder to read.
|
I like this. Any idea when this is going to be released? |
|
At the moment I am deploying a new SNAPSHOT version. To be honest releasing this was not yet a plan, since version 4.4 was released recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
Unsupported statement, which will return any unparsable statement or fragment as a list of tokens.This Feature is OFF by default and can be activated on demand:
However, there are 2 caveats:
BEGIN ... ENDblocks (because its hard to distinguish theENDtoken from anUnsupported StatementStatements()production since the neededLOOKAHEADdoes not work, but results in a stack overflow (maybe a JavaCC bug)Also
IF ... ELSE ...has not been considered yet. I do not think, it is relevant.Fixes #1510