[Cherry Pick] Properly transform caret position in legacyTextInputServiceAdapterAndService #2130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #2117 into
release/1.8.When determining the
focusedRectInRoot,legacyTextInputServiceAdapterAndServiceneeds to transform the position of the caret according to theoffsetMapping.Fixes https://youtrack.jetbrains.com/issue/CMP-8170
Testing
Added a new test, and tested manually with
This could be tested by QA
Release Notes
Fixes - Multiple Platforms
TextField(TextFieldValue)when used with a visual transformation with a non-identity offset mapping (potentially even crashing).