Refactor route handling to support encoded arguments. #2142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated route handling logic in `BrowserHistory` to ensure proper encoding/decoding of route arguments using `decodeURIComponent`. Added test coverage for navigation with encoded parameters to validate the changes and maintain consistency.
eymar
approved these changes
May 28, 2025
terrakok
added a commit
that referenced
this pull request
May 28, 2025
Updated route handling logic in `BrowserHistory` to ensure proper encoding/decoding of route arguments using `decodeURIComponent`. Added test coverage for navigation with encoded parameters to validate the changes and maintain consistency. Fixes https://youtrack.jetbrains.com/issue/CMP-8265 ## Testing Added Browser JS test. ## Release Notes ### Fixes - Navigation - Fix the browser navigation integration problem due encoded routes.
Kpotko
added a commit
that referenced
this pull request
May 28, 2025
Updated route handling logic in `BrowserHistory` to ensure proper encoding/decoding of route arguments using `decodeURIComponent`. Added test coverage for navigation with encoded parameters to validate the changes and maintain consistency. Fixes https://youtrack.jetbrains.com/issue/CMP-8265 ## Testing Added Browser JS test. ## Release Notes ### Fixes - Navigation - Fix the browser navigation integration problem due encoded routes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated route handling logic in
BrowserHistoryto ensure proper encoding/decoding of route arguments usingdecodeURIComponent. Added test coverage for navigation with encoded parameters to validate the changes and maintain consistency.Fixes https://youtrack.jetbrains.com/issue/CMP-8265
Testing
Added Browser JS test.
Release Notes
Fixes - Navigation