Implemented dropmissing functionality#21
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 89.90% 90.62% +0.71%
==========================================
Files 1 1
Lines 218 224 +6
==========================================
+ Hits 196 203 +7
+ Misses 22 21 -1
Continue to review full report at Codecov.
|
Member
|
This looks great! Thanks! |
quinnj
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to solve #7
Dropping rows with missing values can be seen as a special case of filtering, so I just had to develop a function that handles that case and integrate it with the filter function we already had.
Made some tests to prove all was working as expected and a docstring for the dropmissing function to help keep things clear.