Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add open for composed transcodingstreams #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add open for composed transcodingstreams #113

wants to merge 2 commits into from

Conversation

jakobnissen
Copy link
Collaborator

This allows users to easily chain codecs using the do-syntax. Here is an example where the input is chained through four different streams.

julia> using CodecZlib, TranscodingStreams

julia> open(
           i -> first(read(i, String), 10),
           GzipDecompressorStream ∘ NoopStream ∘ GzipCompressorStream ∘ NoopStream,
           "Project.toml"
       )
"name = \"Tr"

@jakobnissen
Copy link
Collaborator Author

I'll add tests if anyone with the permission to merge gives me the thumbs-up :)

@mkitti mkitti self-requested a review August 23, 2022 15:45
mkitti
mkitti reviewed Aug 23, 2022
View reviewed changes
src/stream.jl
Comment on lines +208 to +210
function _open(code::Type{<:Type{T}}, io::IO) where {T <: TranscodingStream}
T(io)
end
Copy link
Member

@mkitti mkitti Aug 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment about what this does?

mkitti
mkitti requested changes Aug 23, 2022
View reviewed changes
Copy link
Member

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@ViralBShah
Copy link
Contributor

@jakobnissen If helpful and if you are interested, I can give you commit access here.

@mkitti
Copy link
Member

mkitti commented Aug 18, 2023

This still needs a test.

@ViralBShah
Copy link
Contributor

This still needs a test.

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkitti mkitti mkitti requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakobnissen @ViralBShah @mkitti