Fix libgit2 SSL certificate searching #18936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
397f38e to
3706486
Compare
3706486 to
971c04c
Compare
|
thanks! with the exception of unrelated toolchain issues on the arm builder, the buildbots seem happy with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two pieces:
libgit2compile time, so that from-source builds andmake binary-distbuilds have a more consistent environmentlibgit2initialization logic and disabling callinggit_libgit2_opts()in favor of setting environment variables so as to workaround Support mbedTLS libgit2/libgit2#3935 (comment).This is a somewhat ugly solution to the problem, but until we hear back from that libgit2 PR on the proper way to fix this, this is the best solution I've got.