fix libgit2 hanging with mbedtls backend due to incomplete writes #19092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find. Merging this faster than usual in order to get it into the nightlies ASAP |
|
Does the problem exist on 0.5? (And should this be backported?) |
|
It does not exist on 0.5, since we're still using openssl with libgit2 on linux there. If we backported #18658 then we would need to backport this as well, but I'm not in a hurry to do that until this has been proven for a while and we haven't found any remaining issues with it. |
vtjnash
added a commit
that referenced
this pull request
Oct 25, 2016
fcard
pushed a commit
to fcard/julia
that referenced
this pull request
Feb 28, 2017
fcard
pushed a commit
to fcard/julia
that referenced
this pull request
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #18871