Fix libgit2 test failure with system libgit2 and OpenSSL #22722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first letter of the error message is in lowercase in some systems, notably Fedora Rawhide with libgit2 0.26 and OpenSSL 1.1.0f.
tkelman
reviewed
Jul 11, 2017
| @@ -1905,7 +1905,8 @@ mktempdir() do dir | |||
| deserialize(f) | |||
| end | |||
| @test err.code == LibGit2.Error.ECERTIFICATE | |||
| @test startswith(err.msg, "The SSL certificate is invalid") | |||
| @test startswith(lowercase(err.msg), | |||
There was a problem hiding this comment.
if libgit2 has changed case convention in their error messages and this wasn't showing up with mbedtls then I guess we should find where in libgit2/libgit2#4173 this error is happening and leave a comment that it should be made consistent
jeffwong
pushed a commit
to jeffwong/julia
that referenced
this pull request
Jul 24, 2017
…2722) The first letter of the error message is in lowercase in some systems, notably Fedora Rawhide with libgit2 0.26 and OpenSSL 1.1.0f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first letter of the error message is in lowercase in some systems,
notably Fedora Rawhide with libgit2 0.26 and OpenSSL 1.1.0f.
Introduced in #22614.