reparameterise PyArray #674
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the parameters of PyArray from
PyArray{T,N,M,L,R}
toPyArray{T,N,F}
:F
is a tuple of symbols, encoding various flags.M
parameter becomes the:mutable
flag.L
parameter becomes the:linear
flag.:contiguous
flag and adds that for even faster access.R
parameter is now implied byT
.The last point means that we no longer allow python objects to be converted to arbitrary eltypes with
pyconvert
. We have an explicit mapping ofT
toR
. For now,T
must be a basic scalar type which equalsR
orT=Py
.