Ab#71788 #24
Merged
Ab#71788 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Application Gateway Orchestrator extension to support multi-target .NET builds, streamline documentation, and bump version metadata.
- Switches project to dual-target .NET6/.NET8 and disables implicit usings
- Cleans up outdated docs and adds new usage sections in
docsource - Updates manifest schema URL, adds
release_project, and refreshes the CHANGELOG
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| integration-manifest.json | Updated schema URL, added release_project, removed obsolete fields |
| docsource/content.md | Added Discovery Job requirements section |
| docsource/azureappgw.md | Adjusted heading levels and added AKV certificate details |
| docsource/appgwbin.md | Adjusted heading levels and added AKV certificate details |
| docs/azureappgw.md and docs/appgwbin.md | Removed outdated, duplicate docs |
| CHANGELOG.md | Reordered and expanded version entries |
| AzureAppGatewayOrchestrator/AzureAppGatewayOrchestrator.csproj | Enabled multi-target build, removed explicit namespace settings |
| .github/workflows/keyfactor-starter-workflow.yml | Updated Actions starter version |
Comments suppressed due to low confidence (2)
AzureAppGatewayOrchestrator/AzureAppGatewayOrchestrator.csproj:3
- Removing the explicit and may alter the default namespace and output assembly name, potentially breaking consumers that rely on the previous names. Consider restoring or confirming these values.
<PropertyGroup>
integration-manifest.json:8
- [nitpick] The manifest uses backslashes in "release_dir" but forward slashes in "release_project". Consider unifying path separators for consistency across environments.
"release_dir": "AzureAppGatewayOrchestrator\\bin\\Release",
spbsoluble
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.