fix(cli): inject agent-switch reminder when switching from Code back to Ask - #14069
Open
Sayandevxyz wants to merge 1 commit into
Open
fix(cli): inject agent-switch reminder when switching from Code back to Ask#14069Sayandevxyz wants to merge 1 commit into
Sayandevxyz wants to merge 1 commit into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge lgtm The transition detection in Files Reviewed (4 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14060
Summary of Changes
When switching from Ask to Code, Kilo injects a
<system-reminder>notifying the model that it has switched to Code mode. However, when switching back from Code to Ask,insertAgentSwitchReminderpreviously exited early withif (mode(input.agent.name) !== "code") return, leaving the model unaware of the transition and often attempting file edits or commands prohibited in Ask mode.This PR:
code-ask-switch.txtreminder instructing the agent that it is now in read-only Ask mode.insertAgentSwitchReminderinpackages/opencode/src/kilocode/session/prompt.tsto inject the appropriate reminder for both Ask → Code and Code → Ask transitions.packages/opencode/test/kilocode/ask-switch-reminder.test.tsverifying injection, message text, and deduplication.@kilocode/cli.Test Plan
bun test ./test/kilocode/ask-switch-reminder.test.ts(all 11 tests pass).bun run script/check-opencode-annotations.ts --worktree(clean pass).