Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(cli): support .xls, .xlsm, and .xlsb spreadsheet formats - #14078

Open
Sayandevxyz wants to merge 1 commit into
Kilo-Org:mainfrom
Sayandevxyz:feat/spreadsheet-formats
Open

feat(cli): support .xls, .xlsm, and .xlsb spreadsheet formats#14078
Sayandevxyz wants to merge 1 commit into
Kilo-Org:mainfrom
Sayandevxyz:feat/spreadsheet-formats

Conversation

@Sayandevxyz

Copy link
Copy Markdown

What

Extends the spreadsheet reader tool to support three additional Excel formats beyond .xlsx:

  • .xls - legacy Excel 97-2003 format
  • .xlsm - macro-enabled Excel workbook
  • .xlsb - Excel Binary Workbook

Why

Users working with older Excel files were getting an unsupported-format error. This change makes the read tool handle all common Excel variants consistently.

Changes

  • packages/opencode/src/kilocode/tool/xlsx.ts - added .xls, .xlsm, .xlsb to accepted extensions
  • packages/opencode/test/kilocode/read-xlsx.test.ts - added test cases for new formats
  • .changeset/add-xls-xlsm-xlsb-spreadsheet-support.md - minor bump changeset

Comment thread bun.lock Outdated
},
"trustedDependencies": [
"web-tree-sitter",
"esbuild",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: Unrelated lockfile churn

This PR only adds spreadsheet format support in packages/opencode/src/kilocode/tool/xlsx.ts and does not add, remove, or change any dependency. The reordering of trustedDependencies and patchedDependencies in bun.lock is incidental (same entries, different order, likely written by a different Bun version) and only adds unrelated diff/merge surface. Consider reverting the bun.lock changes to keep this PR focused.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The change is small and correct. packages/opencode/src/kilocode/tool/xlsx.ts centralizes the accepted extensions in an EXTENSIONS set (.xlsx, .xlsm, .xlsb, .xls, .ods) and relaxes the magic-byte guard to accept the CFB header (D0 CF 11 E0) used by legacy .xls files alongside the existing ZIP header. Because the read tool only invokes the extractor for these extensions, the broader CFB acceptance does not widen the binary path. Tests cover .xls, .xlsm, .xlsb, an invalid .xls, and a non-spreadsheet binary. A user-facing minor changeset is present. No new issues found in the changed code.

Files Reviewed (3 files)
  • .changeset/add-xls-xlsm-xlsb-spreadsheet-support.md - clean
  • packages/opencode/src/kilocode/tool/xlsx.ts - clean
  • packages/opencode/test/kilocode/read-xlsx.test.ts - clean
Previous Review Summary (commit be10708)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit be10708)

Status: 1 Issue Found | Recommendation: Address before merge

The functional change is small and correct: packages/opencode/src/kilocode/tool/xlsx.ts registers .xls/.xlsm/.xlsb and relaxes the magic-byte guard to also accept the CFB header used by legacy .xls files, while .xlsm/.xlsb remain ZIP-based. Tests cover the new formats plus an invalid-input path. The only finding is unrelated lockfile churn.

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
bun.lock 1006 Unrelated reordering of trustedDependencies/patchedDependencies; no dependency change is needed for this feature
Files Reviewed (4 files)
  • .changeset/add-xls-xlsm-xlsb-spreadsheet-support.md - clean
  • bun.lock - 1 suggestion
  • packages/opencode/src/kilocode/tool/xlsx.ts - clean
  • packages/opencode/test/kilocode/read-xlsx.test.ts - clean

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@Sayandevxyz
Sayandevxyz force-pushed the feat/spreadsheet-formats branch from be10708 to c24f6e8 Compare September 12, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant