feat: show permission reasons before approval - #14079
Open
shabeeth2 wants to merge 3 commits into
Open
Conversation
Author
|
Closing for now; the branch will be revised and a new PR opened later. |
shabeeth2
marked this pull request as ready for review
September 13, 2026 00:23
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Reviewed the full diff against current Notes from the review (no action required):
Files Reviewed (39 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #14061
Context
Permission prompts show the requested command or filesystem scope, but do not consistently explain how that access relates to the user's task.
Implementation
Carry task descriptions through existing permission metadata and display a separate italicized Reason in the CLI and VS Code extension. Commands, paths, patterns, and approval controls remain unchanged.
Require a description in the model-facing read schema while preserving compatibility for direct calls that omit it. Missing or blank descriptions preserve existing metadata instead of substituting a generic reason. OpenCode integration uses narrow annotated hooks with Kilo-owned helpers.
Screenshots / Video
CLI and VS Code screenshots are attached above and show the verified behavior.
How to Test
Human verification
The contributor tested the rebuilt CLI and development extension with:
Read C:\Windows\System32\drivers\etc\hosts and explain how localhost names are resolved.Both screenshots show a labeled, italicized task reason separate from the requested scope and approval controls.Reviewer steps
Agent verification and limitations
!/grepsupport.continue_loop_on_denycases). Baseline comparison has not established their cause; this is not a claim that the full suite passes.Checklist