-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add abbreviated lines added/removed to task header #5044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2ee6e82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR adds a GitHub-style diff stats display to the task header, showing lines added/removed in real-time. The implementation is well-structured and follows existing patterns in the codebase. Key Changes:
Files Reviewed (47 files)Core Changes:
UI Components:
Hooks & State:
Tests:
i18n (24 locales):
Notes on Existing CommentsThe existing comment on line 71 of |
f66f705 to
07b31f3
Compare
07b31f3 to
c7ff188
Compare
| * | ||
| * Example: +8 −4 with 4 green boxes, 1 red box, and 0 empty boxes | ||
| */ | ||
| const DiffStatsDisplay = ({ added, removed, maxBoxes = 0, className }: DiffStatsDisplayProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially we had a UI that showed the diff like a github PR lines added/removed display with the boxes. We decided to not show the boxes but I went ahead and kept the functionality in here in case we want it in the future. maxBoxes = 0 hides the boxes
3d44fcf to
47b901d
Compare
47b901d to
2ee6e82
Compare
Uh oh!
There was an error while loading. Please reload this page.