fix(core-schemas): use z.custom() with validator for function types in Zod v4 #5173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
z.function({ input, output })withz.custom<T>()+ validatorProblem
PR #5107 upgraded core-schemas to Zod v4 and attempted to use:
This syntax is incorrect for Zod v4 because:
z.function()is a function factory, not a schemaz.object()"Object literal may only specify known properties, but 'input' does not exist"References:
Solution
Use
z.custom<T>()with runtime validator:This approach:
Why CI Didn't Catch This
CI runs
pnpm check-typeswhich executestsc --noEmitand does detect the error.However, Turbo's remote cache caused the check to be skipped:
package.json(dependency version)Verification
Before (main branch):
After (this PR):
$ pnpm build # DTS ⚡️ Build successTest Plan
pnpm check-typespnpm build(ESM, CJS, DTS all pass)PollingOptionstype still correcttypeof val === "function"cc #5107