Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CLI - Add async condense context handling with completion feedback #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eshurakov merged 2 commits into from
Jan 20, 2026
Merged

CLI - Add async condense context handling with completion feedback #5230

eshurakov merged 2 commits into from
Jan 20, 2026

Conversation

@eshurakov
Copy link
Contributor

@eshurakov eshurakov commented Jan 20, 2026

Summary

Adds async handling for the condense context command in the CLI with proper completion and error feedback.

Changes

  • Add new Jotai atoms for managing pending condense requests (condense.ts)
  • Add useCondense hook that provides condenseAndWait function with timeout handling (useCondense.ts)
  • Update condense command to await completion and display success/error messages
  • Add condenseAndWait to command context for use in commands
  • Add test coverage for condense atoms and useCondense hook

Before

CLI would send condense request but not wait for completion:

{"type":"system","content":"Condensing conversation context..."}
{"event":"session_synced"}

After

CLI now waits for completion and shows result:

{"type":"system","content":"Condensing conversation context..."}
{"type":"system","content":"Context condensation complete."}
{"event":"session_synced"}

Or on error:

{"type":"system","content":"Condensing conversation context..."}
{"say":"condense_context_error","content":"Context size increased..."}
{"type":"system","content":"Context condensation complete."}

@eshurakov
Add async condense context handling with state atoms
ba36293 
Introduces state atoms and hooks for managing async condense context requests, including pending request tracking, resolution, and timeout handling. Refactors the condense command to use a new condenseAndWait method, updates CommandContext and related tests, and integrates condense request handling into the message handler effect. Adds comprehensive tests for condense state management.
@eshurakov
Add tests for useCondense hook and changeset
3d21b02
@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2026

🦋 Changeset detected

Latest commit: 3d21b02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kilocode/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kiloconnect
Copy link
Contributor

kiloconnect bot commented Jan 20, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

This PR adds async condense context handling with completion and error feedback in auto mode. The implementation is well-structured and follows existing patterns in the codebase.

Key Changes:

  • New useCondense hook that provides condenseAndWait function for async condense operations
  • New Jotai atoms for managing pending condense requests with timeout handling
  • Updated condenseCommand to use the new async pattern with proper success/error feedback
  • Comprehensive test coverage for all new functionality

Highlights:

  • ✅ Proper Promise-based async handling with 60-second timeout
  • ✅ Correct cleanup of timeouts when requests are resolved or removed
  • ✅ Error handling for both timeout and sendMessage failures
  • ✅ Type-safe integration with CommandContext interface
  • ✅ Comprehensive test coverage including timeout, success, and error scenarios
Files Reviewed (9 files)
  • .changeset/cli-async-condense-handling.md - Changeset for the patch
  • cli/src/commands/__tests__/condense.test.ts - Updated tests for condense command
  • cli/src/commands/__tests__/helpers/mockContext.ts - Added mock for condenseAndWait
  • cli/src/commands/condense.ts - Updated to use async condenseAndWait
  • cli/src/commands/core/types.ts - Added condenseAndWait to CommandContext
  • cli/src/state/atoms/condense.ts - New atoms for condense state management
  • cli/src/state/atoms/__tests__/condense.test.ts - Tests for condense atoms
  • cli/src/state/hooks/useCommandContext.ts - Integrated useCondense hook
  • cli/src/state/hooks/useCondense.ts - New hook for condense operations

@eshurakov eshurakov requested a review from a team January 20, 2026 11:14
@eshurakov eshurakov merged commit 9f2d1c4 into main Jan 20, 2026
12 checks passed
@eshurakov eshurakov deleted the eshurakov/cli-condense-in-auto-mode branch January 20, 2026 11:30
This was referenced Jan 20, 2026
Merged
Open
Open
Open
Open
Open
Closed
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marius-kilocode marius-kilocode marius-kilocode approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eshurakov @marius-kilocode