fix(cli): Fix empty tool output for list_files and search_files #5250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 700deb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Previous Issue ResolvedThe previous review flagged an issue with incorrect content checking for tool messages. This has been fixed in the current version. The code now properly parses the JSON and checks the let hasContent = false
try {
const parsed = JSON.parse(msg.text || "{}")
hasContent = parsed.content && parsed.content.trim().length > 0
} catch {
// If parsing fails, fall back to checking text directly
hasContent = Boolean(msg.text && msg.text.trim().length > 0)
}Files Reviewed (3 files)
SummaryThis PR adds a CLI-only workaround for an extension bug where
The implementation is well-structured and the tests are thorough. |
The previous implementation checked if msg.text was non-empty, but for tool messages, msg.text is always a JSON string containing a content property. Even when content is empty, the text field itself is non-empty. This fix parses the JSON and checks if the content field is non-empty, with a fallback to checking text directly if parsing fails.
iscekic
approved these changes
Jan 22, 2026
This was referenced Jan 22, 2026
Merged
maywzh
pushed a commit
to maywzh/kilocode
that referenced
this pull request
Jan 25, 2026
…-Org#5250) * fix(cli): Fix empty tool output for list_files and search_files * fix(cli): Parse JSON to check content field for tool messages The previous implementation checked if msg.text was non-empty, but for tool messages, msg.text is always a JSON string containing a content property. Even when content is empty, the text field itself is non-empty. This fix parses the JSON and checks if the content field is non-empty, with a fallback to checking text directly if parsing fails.
maywzh
pushed a commit
to maywzh/kilocode
that referenced
this pull request
Jan 25, 2026
…-Org#5250) * fix(cli): Fix empty tool output for list_files and search_files * fix(cli): Parse JSON to check content field for tool messages The previous implementation checked if msg.text was non-empty, but for tool messages, msg.text is always a JSON string containing a content property. Even when content is empty, the text field itself is non-empty. This fix parses the JSON and checks if the content field is non-empty, with a fallback to checking text directly if parsing fails.
catrielmuller
pushed a commit
that referenced
this pull request
Jan 26, 2026
* fix(cli): Fix empty tool output for list_files and search_files * fix(cli): Parse JSON to check content field for tool messages The previous implementation checked if msg.text was non-empty, but for tool messages, msg.text is always a JSON string containing a content property. Even when content is empty, the text field itself is non-empty. This fix parses the JSON and checks if the content field is non-empty, with a fallback to checking text directly if parsing fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an intermittent issue where
list_files(recursive) andsearch_filestools show "Total: 0 items" and "Found: 0 matches" even when files exist.Problem
The issue is a race condition in message handling that occurs more frequently in long-running sessions. When the extension sends a partial message followed by a complete message, the complete message can sometimes be lost or rejected due to IPC timing issues. The
hidePartialMessagesfilter then removes the partial message, showing "0 items".Solution
Added
autoCompleteOrphanedPartialTools()function that marks partial tool messages as complete when:This acts as a safety net to ensure tool results are displayed even when the complete message is lost.
Technical Details
type: "ask"withask: "tool", NOTtype: "say"withsay: "tool"updateChatMessagesAtomTesting
Files Changed
cli/src/state/atoms/extension.ts- AddedautoCompleteOrphanedPartialTools()functioncli/src/state/atoms/__tests__/tool-message-completion.spec.ts- Added tests.changeset/fix-cli-partial-tool-messages.md- Changeset