fix(core-schemas): add openai-responses provider schema #5374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1f06759 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chrarnoldus
approved these changes
Jan 25, 2026
openai-responses exists in the CLI provider list but the core-schemas and CLI config schema are not synced, leaving validation and model mapping incomplete. - packages/core-schemas: add openAIResponsesProviderSchema - cli/src/config/types.ts: re-export schema/type - cli/src/config/mapper.ts: map openAiModelId - cli/src/config/schema.json: add provider enum + validation blocks pnpm check-types cd cli && pnpm test
1b627cb to
1f06759
Compare
Contributor
Author
|
@chrarnoldus the conflict was resolved, please take a look, thanks ;) |
Collaborator
|
Thanks! |
This was referenced Jan 25, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
openai-responses provider exists in the CLI provider list but the TypeScript type definition and config validation schema were not synced, causing validation failures and missing model field mapping.
Similar issue to #5359 (openai-codex fix).
Implementation
packages/core-schemas/src/config/provider.ts:
openAIResponsesProviderSchema(matches openAI schema structure)providerConfigSchemadiscriminated unionOpenAIResponsesProviderConfigtypekilocode_change(per CLAUDE.md - packages/ requires markers)cli/src/config/types.ts:
cli/src/config/mapper.ts:
openai-responsescase togetModelIdForProvider(usesopenAiModelId)cli/src/constants/providers/models.ts:
openai-responsescase togetModelIdKey(returnsopenAiModelId)cli/src/config/schema.json:
Screenshots
N/A (type definition and config validation fix)
How to Test
Get in Touch
@PeterDaveHello