This repository was archived by the owner on Apr 4, 2022. It is now read-only.
Retrieve timestamps (ETag) of plural endpoints #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a getETag method for collections and buckets
* Update README to document methods and no longer suggest use of last_modified
|
Tests fail because of #424 |
glasserc
approved these changes
Jun 3, 2019
README.md
Outdated
| @@ -1168,10 +1191,31 @@ Sample result: | |||
| 42 | |||
| ``` | |||
|
|
|||
| #### Options | |||
| #### options | |||
There was a problem hiding this comment.
I think this should remain capitalized?
README.md
Outdated
| @@ -1142,7 +1165,7 @@ Sample result: | |||
|
|
|||
| The result object exposes the following properties: | |||
|
|
|||
| - `last_modified`: the [collection's timestamp](http://kinto.readthedocs.io/en/stable/api/1.x/timestamps.html). This value is opaque and should be reused as is, eg. passing it as a `since` option (see [Generic bucket and collection options](#generic-bucket-and-collection-options)) | |||
| - `last_modified`: the [collection's timestamp](http://kinto.readthedocs.io/en/stable/api/1.x/timestamps.html). | |||
There was a problem hiding this comment.
Maybe we should note that it is not the same as the timestamps you get from getCollectionsTimestamp() etc.
There was a problem hiding this comment.
Actually, it is the same :) I'll add a note
README.md
Outdated
|
|
||
| - `headers`: Custom headers object to send along the HTTP request | ||
| - `retry`: Number of retries when request fails (default: 0) | ||
| - `headers`: custom headers object to send along the http request |
There was a problem hiding this comment.
I think HTTP could remain capitalized.
README.md
Outdated
| @@ -552,6 +555,26 @@ Sample result: | |||
|
|
|||
| This method accepts the [generic parameters for sorting, filtering and paginating results](#generic-options-for-list-operations). | |||
|
|
|||
| ### Collections list timestamp | |||
|
|
|||
| The timestmap of the collections list is used for the `since` option in the [generic parameters for sorting, filtering and paginating results](#generic-options-for-list-operations). | |||
There was a problem hiding this comment.
You have timestamp typoed as timestmap a few places.
src/bucket.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Retrieves the ETag of the collection list, for use with the `since` filtering option. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #351