This repository was archived by the owner on Apr 4, 2022. It is now read-only.
Add response types and emit TypeScript declarations #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@leplatrem If everything looks good, could you merge and release a new alpha version? |
leplatrem
approved these changes
Feb 11, 2020
|
@leplatrem merged! You can view a diff of the Gecko build here. It's primarily differences between how Babel and TypeScript emit certain features. There are a few actual implementation changes, but those all passed tests so it should be fine! Let me know how it goes! (Also, if you wouldn't mind, could you do another alpha release so we can get the TypeScript PR for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that I've confirmed these types work well with how the library is being used in
kinto.js, I think it's time to enable the declarations! This is an important step to finishing the TypeScript conversion forkinto.js.This PR also removes
"use strict";since TypeScript emits that by default.This PR also makes a slight modification to the browser build process. Because we're exporting types for use by the TypeScript compiler in
kinto.js, Rollup wants to export those types in the browser bundle as well, which causes issues since the browser bundle is a UMD module. This PR adds a newindex.browser.tsfile much likeindex.fx.tsthat just re-exports theKintoClient. TypeScript 3.8 will introduce type only imports that get removed once passed through the compiler, so this is just a temporary solution until 3.8 is released. I highly doubt we'll cut a non-prerelease prior to the release of 3.8, but I'd rather have the repo in a working state in the interim!This PR supersedes #562, and fixes #517.