This repository was archived by the owner on Apr 4, 2022. It is now read-only.
Replace EventEmitter with interface and make it optional #695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our usage of EventEmitter with an interface with the following shape:
This allows the consumer to provide their own emitter, or opt not to. For users who opt to use a small emitter like mitt, this should result in a decently smaller bundle size.
I also updated the
HTTP
tests to run the entire suite with anEventEmitter
, withmitt
, and without an event emitter at all.Fixes #679