Setup Wizard: Steps: Use Named Identifiers #1004
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
ciccio-kit
approved these changes
Feb 3, 2026
|
|
||
| // Define the step the user is on in the setup process. | ||
| $this->step = ( filter_has_var( INPUT_GET, 'step' ) ? absint( filter_input( INPUT_GET, 'step', FILTER_SANITIZE_NUMBER_INT ) ) : 1 ); | ||
| $this->step = ( filter_has_var( INPUT_GET, 'step' ) ? filter_input( INPUT_GET, 'step', FILTER_SANITIZE_FULL_SPECIAL_CHARS ) : 'start' ); |
There was a problem hiding this comment.
nitpick (non-blocking): this would be pretty much impossible to exploit, bust since this value is used directly in a include_once at L381 of this same file, what do you think about adding another check here to fallback to 'start' if step is not one of the predefined string values we expect?
Contributor
Author
There was a problem hiding this comment.
Completely agree. Thanks for spotting this - have updated to check the step is registered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the Setup Wizard steps to use named identifiers instead of numeric indices - for example,
start,configurationandfinish. Future PR's will rely on this when optionally adding steps - for example, if third party form plugins are detected, the onboarding Setup Wizard might add an additional step for the user to automatically replace third party forms with Kit forms.Testing
Existing tests pass.
Checklist