Complete Activity Group Support #1238
Conversation
|
I think this is ready for review. @BryonLewis PTAL. |
BryonLewis
left a comment
There was a problem hiding this comment.
The UI features are really nice. I like the range selector and how that works especially with taking current frame and allowing the multiple frame ranges.
There are a few things that don't fit directly into code comments so I'm going to list them below:
- The dropdown for group type changes in the group list needs to be disabled in ReadOnly Mode
- I think there may still be a reason to view detailed ranges and information about a group while in ReadOnly mode. The current implementation locks out viewing that info because selecting a group has the immediate effect of putting it into edit mode. I think the act of editing ranges and selecting new tracks for a group should be the things locked out during edit mode.
- LOW PRIORITY QUESTION: Wondering if the Group Event Viewer should handle gaps like it does for interpolation when a group is selected?
- Within
useModeManager.ts-handleUnstageFromMergeif you have a track and group selected with only the track as a member and delete the track you will get conflicts as it tries to remove a member from a group that has already been deleted. The deletion of a track should probably begin with deselecting the group at the same time. - Splitting of tracks within a group can result in some weird behavior. It may be best to not split tracks that are in groups and require the track to be clean (not in a group) before splitting.
- Deletion of groups through the group type list needs to be clearer in the text about what it is doing. Currently it's using the same text as deleting tracks of visible types when really you're deleting the selected/visible groups and not the tracks themselves.
| if (readonlyState.value) { | ||
| prompt({ title: 'Read Only Mode', text: 'This Dataset is in Read Only mode, no edits can be made.' }); | ||
| } else { |
There was a problem hiding this comment.
This prevents detailed viewing of the groups while in readOnly mode.
I'm thinking the readonly mode should be handled in the selecting/modification in the TrackDetailsPanel.vue file as well as selecting to add new tracks to the group?
dc810d7 to
2ad74dd
Compare
|
@BryonLewis I think I responded to everything except the below
IDK, maybe. I want to get feedback from Kellie first. I also added a new dataset to the integration tests for groups (needs to be downloaded) and the DIVE json file is now part of export->everything because otherwise there would be no way to export group annotations (VIAME csv doesn't support them). |
BryonLewis
left a comment
There was a problem hiding this comment.
The <Type-Picker> in the also needs the read-only-mode attribute applied to prevent changing group types when in readOnlyMode.
Other than that everything mentioned seems to be resolved.
ghost
left a comment
There was a problem hiding this comment.
LGTM, nice work on this whole thing and creating a UI to make sense of it.
BryonLewis
left a comment
There was a problem hiding this comment.
Let's approve this with the Right account.
* Progress on activity group editing * Progress on correct editing behavior * Finalize editing * Documentation updates * Update documentation * Add shortcut docs * Wip * KPF import support desktop * icon * Fix docs add tests * whatdo * Remove multi-file inputs * Upgrade node for electron-builder * Respond to comments * Backend fixes * Add readOnlyMode to TypePicker in GroupList
* Activity Group Support (#1205) * Activity Groups * Move Image Enhancement * wip * GroupItem * Refactor Filter Controls * Complete backend support for activity groups with migrations * Refactor of GroupStore, Filter Controls, Filter List * Group filtering support * test fixes * sidebar * sidebar update * Respond to comments * Fix tests * fixing final test (#1234) Co-authored-by: BryonLewis <[email protected]> * Release 1.9.0-beta.1 * Group Creation (#1237) * WIP Group Creation * Edit type and select. Refactor TypePicker * Progress toward creation and editing of activity groups * Group membership add and remove * Update package.json * Complete Activity Group Support (#1238) * Progress on activity group editing * Progress on correct editing behavior * Finalize editing * Documentation updates * Update documentation * Add shortcut docs * Wip * KPF import support desktop * icon * Fix docs add tests * whatdo * Remove multi-file inputs * Upgrade node for electron-builder * Respond to comments * Backend fixes * Add readOnlyMode to TypePicker in GroupList * Update package.json * Include buildResources * Server/kpf support v2 (#1235) * Work in progress * Finalize KPF support * Fully move to new annotation schema in all parsers * Liint fix * Add extra meta in zip extraction * Fix * Fix merge conflict Co-authored-by: BryonLewis <[email protected]>
Summary
src/needs to use relative imports in order to build the library correctly.TypeList.vuebecause it was replaced byFilterList.vuebuild/icon.pnguseVirtualScrollso I can use it in both virtual-scroll-list components.fixes #850