Job queue size #1267
Merged
Job queue size #1267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryonLewis
requested changes
Jul 6, 2022
Collaborator
BryonLewis
left a comment
There was a problem hiding this comment.
Works mostly as intended. I think that the having the number of awaiting jobs may be necessary to indicate that there are X items in the queue currently instead of the currently in progress jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the size of the job queue to all users.
This is an imperfect solution because when another user in the system creates a job, it won't show up here because User A won't get push notifications about user B's jobs. It will update for changes in User A's job status, but otherwise might require a page reload to be correct.
fixes #1260