Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add assert error for requires() when request param is not Request type #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kludex merged 2 commits into from
May 30, 2026
Merged

Add assert error for requires() when request param is not Request type #3298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64ede9b
add assert error for requires() when request param is not Request type
KeeganOP May 27, 2026
e200db3
Merge branch 'main' into requires_assert_error
Kludex May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions starlette/authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ def decorator(
@functools.wraps(func)
async def websocket_wrapper(*args: _P.args, **kwargs: _P.kwargs) -> None:
websocket = kwargs.get("websocket", args[idx] if idx < len(args) else None)
assert isinstance(websocket, WebSocket)
assert isinstance(websocket, WebSocket), (
"Parameter with name 'websocket' is required to be of type 'WebSocket'"
f" not '{type(websocket).__name__}'"
)

if not has_required_scope(websocket, scopes_list):
await websocket.close()
Expand All @@ -59,7 +62,9 @@ async def websocket_wrapper(*args: _P.args, **kwargs: _P.kwargs) -> None:
@functools.wraps(func)
async def async_wrapper(*args: _P.args, **kwargs: _P.kwargs) -> Any:
request = kwargs.get("request", args[idx] if idx < len(args) else None)
assert isinstance(request, Request)
assert isinstance(request, Request), (
f"Parameter with name 'request' is required to be of type 'Request' not '{type(request).__name__}'"
)

if not has_required_scope(request, scopes_list):
if redirect is not None:
Expand All @@ -76,7 +81,9 @@ async def async_wrapper(*args: _P.args, **kwargs: _P.kwargs) -> Any:
@functools.wraps(func)
def sync_wrapper(*args: _P.args, **kwargs: _P.kwargs) -> Any:
request = kwargs.get("request", args[idx] if idx < len(args) else None)
assert isinstance(request, Request)
assert isinstance(request, Request), (
f"Parameter with name 'request' is required to be of type 'Request' not '{type(request).__name__}'"
)

if not has_required_scope(request, scopes_list):
if redirect is not None:
Expand Down