Fix/assert to typeerror#3309
Closed
NEFORCEO wants to merge 6 commits into
Closed
Conversation
Contributor
|
related to: #3298 (comment) |
KeeganOP
approved these changes
May 31, 2026
Author
Done. I've changed it to |
Owner
|
I'd actually prefer to not have this kind of plumbing for the time being. Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
assertstatements with explicitTypeErrorraises in@requiresdecorator (authentication.py) andOpenAPIResponse.render(schemas.py).assertstatements are silently removed when Python runs with the-O(optimize) flag, turning helpful type mismatch messages into crypticAttributeErrors deeper in the call stack. Usingraise TypeErrorensures the check always runs regardless of optimization level.Changed files:
starlette/authentication.py— 3 places:websocket_wrapper,async_wrapper,sync_wrapperstarlette/schemas.py—OpenAPIResponse.renderAdded tests:
tests/test_authentication.py— 3 new tests verifyingTypeErroris raised when sync/async request wrapper and websocket wrapper receive wrong argument typestests/test_schemas.py— 1 new test verifyingTypeErroris raised whenOpenAPIResponsereceives a non-dictChecklist