Why don't you just call the api function from the __call function?

@GrahamCampbell that's not a bad idea. I could easily add the camel cased aliases too. WIll do that now.

Done!

The usage of the magic api should be covered by a few tests too

Where is the best place to test this? ClientTest.php?

The new way calling the old one. Not sure it's very cool. The __call method should be called by the old (and deprecated ?) api method...

[edit] and test in ClientTest.php ofc.

@stof for the tests, would this make sense?

/**
 * @test
 * @dataProvider getApiClassesProvider
*/
public function shouldGetMagicApiInstance($apiName, $class)
{
    $client = new Client();

    $this->assertInstanceOf($class, $client->$apiName());
}

Where is the best place to test this? ClientTest.php?

yes

The new way calling the old one

well, if we decide that ->api($name) is deprecated, we should implement real methods rather than building it with __call. The question is whether you want to mark it as deprecated already

What error message should be thrown by BadMethodCallException?

• Tests are added.
• Catching of InvalidArgumentException which in turn throws BadMethodCallException.

Make sense?

@cursedcoder can we see this merged? :)

if @stof is ok with it

👍

Awesome! :)

@cursedcoder Please bump the package version to 1.3.x when releasing this, to start followign semver for the version numbers (and I think it deserves being mentionned in the changelog of the release)

The branch alias is already for 1.3.

I know I might be out of place, but I am going through the code, and am curious why this implementation was needed.

Why use magic methods here? Just for the aliasing, or is there any other reason I don't understand?
Thanks in advance for the info :)

I ended up here but it is not explained :D