Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Added check for lint cmd to handle empty or only comment files.#2099

Merged
shivaygupta-dotcom merged 6 commits into
mainfrom
fix/lint-cmd-comment
Jun 5, 2026
Merged

fix: Added check for lint cmd to handle empty or only comment files.#2099
shivaygupta-dotcom merged 6 commits into
mainfrom
fix/lint-cmd-comment

Conversation

@shivaygupta-dotcom

@shivaygupta-dotcom shivaygupta-dotcom commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GH: #2091

Added validation in deck file lint to handle empty state files and files containing only comments.

@codecov-commenter

codecov-commenter commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.27%. Comparing base (35b548f) to head (3720a3b).

Files with missing lines Patch % Lines
tests/integration/test_utils.go 0.00% 20 Missing ⚠️
lint/lint.go 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2099      +/-   ##
==========================================
- Coverage   32.39%   32.27%   -0.13%     
==========================================
  Files          77       77              
  Lines        7201     7229      +28     
==========================================
  Hits         2333     2333              
- Misses       4671     4699      +28     
  Partials      197      197

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shivaygupta-dotcom shivaygupta-dotcom added skip-konnect Skip Konnect Integration tests in CI skip-ee Skip Enterprise Integration Tests in CI skip-oss Skip Open Source Integration Tests in CI and removed skip-ee Skip Enterprise Integration Tests in CI skip-oss Skip Open Source Integration Tests in CI labels Jun 5, 2026
@shivaygupta-dotcom shivaygupta-dotcom removed the skip-konnect Skip Konnect Integration tests in CI label Jun 5, 2026
Prashansa-K
Prashansa-K reviewed Jun 5, 2026
View reviewed changes
Comment thread lint/lint.go Outdated
Prashansa-K
Prashansa-K reviewed Jun 5, 2026
View reviewed changes
Comment thread lint/lint.go Outdated
@Prashansa-K

Prashansa-K commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Changes look fine. Will approve once CI passes.

@shivaygupta-dotcom shivaygupta-dotcom added skip-konnect Skip Konnect Integration tests in CI skip-ee Skip Enterprise Integration Tests in CI labels Jun 5, 2026
@shivaygupta-dotcom shivaygupta-dotcom merged commit 267523b into main Jun 5, 2026
18 checks passed
@shivaygupta-dotcom shivaygupta-dotcom deleted the fix/lint-cmd-comment branch June 5, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prashansa-K Prashansa-K Prashansa-K approved these changes

Assignees

No one assigned

Labels

skip-ee Skip Enterprise Integration Tests in CI skip-konnect Skip Konnect Integration tests in CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shivaygupta-dotcom @codecov-commenter @Prashansa-K