fix(compose): add depends_on health checks for PostgreSQL#741
Open
zhfeng wants to merge 1 commit into
Open
Conversation
Kong's kong and migration services start before PostgreSQL is ready, causing connection errors. Add `condition: service_healthy` to depends_on so services wait for the DB health check to pass before starting. Co-Authored-By: Claude Opus 4.7 <[email protected]>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
condition: service_healthytodepends_onforkong-migrationsandkong-migrations-upservices so they wait for PostgreSQL to be healthy before running migrationsdepends_onto thekongservice to wait for both the database (healthy) and migrations (completed) before startingProblem
When running
docker-compose --profile database up, Kong starts before PostgreSQL is ready, causing connection errors:This requires a manual restart of the Kong container after PostgreSQL is ready.
Test plan
docker-compose --profile database upfrom a clean statecurl http://localhost:8001/returns Kong's Admin API response🤖 Generated with Claude Code