Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Android compilation fix #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2025
Merged

Android compilation fix #1218

merged 2 commits into from
May 26, 2025

Conversation

Jolanrensen
Copy link
Collaborator

@Jolanrensen Jolanrensen commented May 26, 2025 •
edited
Loading

Fixes #1217.

Needed:

  • moving duplicate packages to different name
  • adding an extra line to android.packaging.resources.pickFirsts for Deephaven

@Jolanrensen Jolanrensen marked this pull request as ready for review May 26, 2025 12:20
@Jolanrensen
Copy link
Collaborator Author

image
Seems to work! Also builing and running correctly on android now :)

@Jolanrensen Jolanrensen merged commit 5f5f6a1 into master May 26, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaleslaw zaleslaw zaleslaw approved these changes

@koperagen koperagen Awaiting requested review from koperagen

@AndreiKingsley AndreiKingsley Awaiting requested review from AndreiKingsley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(!) DataFrame 1.0.0-Beta2 is incompable with Android
2 participants
@Jolanrensen @zaleslaw