update groupBy documentation #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaleslaw
reviewed
Oct 11, 2023
| @@ -18,6 +18,15 @@ import kotlin.reflect.KProperty | |||
|
|
|||
| // region DataFrame | |||
|
|
|||
| /** | |||
| * Column for grouping can be created inplace | |||
There was a problem hiding this comment.
The comment looks like a good candidate for a NOTE: section, but not like a documentation for a function (probably you leave id with TODO: add docs and with NOTE section
zaleslaw
reviewed
Oct 11, 2023
| /*<!--*/ | ||
| call_DataFrame(function() { DataFrame.addTable({ cols: [{ name: "<span title=\"firstName: String\">firstName</span>", children: [], rightAlign: false, values: ["Alice"] }, | ||
| { name: "<span title=\"lastName: String\">lastName</span>", children: [], rightAlign: false, values: ["Wolf"] }, | ||
| { name: "<span title=\"name: DataRow\">name</span>", children: [0, 1], rightAlign: false, values: ["<span class=\"formatted\" title=\"firstName: Alice\nlastName: Wolf\"><span class=\"structural\">{ </span><span class=\"structural\">firstName: </span>Alice<span class=\"structural\">, </span><span class=\"structural\">lastName: </span>Wolf<span class=\"structural\"> }</span></span>"] }, |
There was a problem hiding this comment.
Do we have described somewhere a process how to generate these html files?
zaleslaw
approved these changes
Oct 11, 2023
b878f88 to
7d7168d
Compare
|
@Jolanrensen Have a look at the last commit please, it's related to new static table |
add docs for moveToTop + emphasize important groupBy use case
7d7168d to
d123db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously reported that moveToTop is undocumented :) Plus i want emphasize important
groupBy expruse case for those who don't know