Compiler plugin update #755
Conversation
Dumps change after updating the compiler, or when the library changes, and it leads to conflicts. It would be better to add more "checks" in the test code itself, and only opt in FIR_DUMP directive for individual tests when needed
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/codeGen/MarkersExtractor.kt
Outdated
Show resolved
Hide resolved
| FILE: read.kt | ||
| package org.jetbrains.kotlinx.dataframe | ||
|
|
||
| FILE: propertiesOrder.kt | ||
| public final fun box(): R|kotlin/String| { |
There was a problem hiding this comment.
You wanted to exclude these files right?
There was a problem hiding this comment.
I opt in fir dump for this file specifically. Would be good to have a few of them present to track changes in generated code, like for example there's this @Order annotation and IDE plugin relies on it
| @@ -28,9 +28,8 @@ FILE: selectDuringTyping.kt | |||
| } | |||
|
|
|||
| local abstract class ExplodeSchema_94 : R|<local>/ExplodeSchema_94I| { | |||
| public abstract var scope0: R|<local>/Scope0| | |||
| @R|org/jetbrains/kotlinx/dataframe/annotations/ScopeProperty|() public abstract val scope0: R|<local>/Scope0| | |||
| public get(): R|<local>/Scope0| | |||
There was a problem hiding this comment.
should the fir files in diagnostics also be included, or are they fine?
There was a problem hiding this comment.
For diagnostics tests, FIR dumps are needed to verify that warnings/errors were actually reported, it seems
| * This annotation serves to distinguish between the two where needed | ||
| */ | ||
| @Target(AnnotationTarget.PROPERTY) | ||
| public annotation class ScopeProperty |
There was a problem hiding this comment.
do you use this annotation already somewhere? I'm curious to see how/where it's used :)
There was a problem hiding this comment.
What do you mean by use? :o
Here generated property is annotated
plugins/kotlin-dataframe/src/org/jetbrains/kotlinx/dataframe/plugin/extensions/TokenGenerator.kt
There was a problem hiding this comment.
Plus other things from the same commit
There was a problem hiding this comment.
Ooh so this annotation class is only used on generated properties. That wasn't clear to me
|
Generated sources will be updated after merging this PR. |
Review commits one by one, they are not related to each other
Note that i provided explanations b154937 in commit message
Here you can find how to enable fir dump for an individual test
plugins/kotlin-dataframe/testData/box/propertiesOrder.kt