Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

koperagen
Copy link
Collaborator

No description provided.

@koperagen koperagen requested a review from zaleslaw July 16, 2024 12:04
@koperagen koperagen self-assigned this Jul 16, 2024
@koperagen koperagen added the enhancement New feature or request label Jul 16, 2024
@koperagen koperagen added this to the 0.14.0 milestone Jul 16, 2024
<!---FUN convertAsFrame-->

```kotlin
df.convert { name }.asFrame { it.add("fullName") { "$firstName $lastName" } }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, doc updates!

@@ -111,6 +114,9 @@ public inline fun <T, C, reified R> Convert<T, C>.with(
noinline rowConverter: RowValueExpression<T, C, R>
): DataFrame<T> = with(Infer.Nulls, rowConverter)

public fun <T, C, R> Convert<T, DataRow<C>>.asFrame(body: ColumnsContainer<T>.(ColumnGroup<C>) -> DataFrame<R>): DataFrame<T> =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it covered by unit test? please add

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Collaborator

@zaleslaw zaleslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a JUnit test is missed

Copy link
Contributor

Generated sources will be updated after merging this PR.
Please inspect the changes in here.

@koperagen koperagen merged commit 0e97e5b into master Jul 17, 2024
@koperagen koperagen deleted the convert-as-frame branch August 26, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants