-
Notifications
You must be signed in to change notification settings - Fork 8
Feat/sol sign ability #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spacesailor24
wants to merge
20
commits into
feat/delegated-wks
Choose a base branch
from
feat/sol-sign-ability
base: feat/delegated-wks
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
|
60cae6d
to
23f0b62
Compare
867537c
to
d1b6f64
Compare
23f0b62
to
a4e5636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BRANCHES OFF OF #336, SO IT MUST BE MERGED AFTER
Adds a new Vincent Ability to utilizes
getVincentRegistryAccessControlCondition
from #336 to decrypt providedciphertext
anddataToEncryptHash
to get the raw Solana private key and sign provided SOL transactionsType of change
How Has This Been Tested?
Adds a new E2E test which generates it's own SOL keypair, encrypts it using the ACCs generated by
getVincentRegistryAccessControlCondition
, then executes theprecheck
andexecute
functions which result in a signed SOL transaction. The E2E test also broadcasts the signed tx and validates the tx was included in a blockpackages/apps/abilities-e2e/test-e2e/solana-transaction-signer.spec.ts
Checklist:
nx release plan
) describing my changes and the version bump